(maint) A number of fixes for rerunning tests on docker containers #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 27, 2019 14:35
Previously, this would provision the container if it wasn't found or if provisioning was explicitly enabled, which is the default option. It feels like you shouldn't need to explicitly disable provisioning to reuse running containers.
This will allow us to determine elsewhere if we're using an existing container and can skip provisioning steps.
This is equivalent to preserving the host for non-containerized runs. If this option is set, the container will not be destroyed on test completion and the image the container is based on will not be removed.
underscorgan
force-pushed
the
maint/master/docker-dev-improvements
branch
from
db59d50
to
feec770
Compare
smcelmurry
approved these changes
Jul 1, 2019
underscorgan
force-pushed
the
maint/master/docker-dev-improvements
branch
from
ede6d79
to
feec770
Compare
|
@smcelmurry @kevpl is there anything else needed here before this can get merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for more details
Related to puppetlabs/beaker-puppet#117