Fix: Too many authentication failures #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
test this please |
sbeaulie
reviewed
Dec 30, 2019
lib/beaker/hypervisor/docker.rb
Outdated
| @@ -224,6 +224,7 @@ def provision | |||
| :password => root_password, | |||
| :port => port, | |||
| :forward_agent => forward_ssh_agent, | |||
| :keys_only => 'yes', | |||
There was a problem hiding this comment.
Thanks for your contribution @b4ldr. It seems to me that we are using username/password to authenticate the SSH connection, so disabling looking through the ssh-agent for keys makes sense. My worry is that if anyone is using ssh-agent to connect, this would break it. Another solution would be to set the "auth_methods" to change the order and try the password method first, like so:
Suggested change
| :keys_only => 'yes', | |
| :auth_methods => ['password', 'publickey', 'hostbased', 'keyboard-interactive'] |
By default ssh will try all keys stoered in the ssh agent when connecting to a server. If a agent has many keyes loaded it can leed to the server responding with the following error before the username/password pair is tried: Net::SSH::Disconnect - disconnected: Too many authentication failures This PR updates the ssh config to use change the `:auth_methods` order so password authentication is prefered
b4ldr
force-pushed
the
to_many_auth_failures
branch
from
f109914
to
d5a94e4
Compare
|
bump: this has been updated as per the recomendation thanks |
|
Thank you for your contribution, I will release it today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default ssh will try all keys stoered in the ssh agent when
connecting to a server. If a agent has many keyes loaded it can leed to
the server responding with the following error before the
username/password pair is tried:
Net::SSH::Disconnect - disconnected: Too many authentication failures
This PR updates the ssh config to use :keys_only which translates to the
ssh confi IdentitiesOnly