Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker support and update github actions #32

Merged
merged 1 commit into from
Feb 28, 2021

Conversation

trevor-vaughan
Copy link
Contributor

  • Ensure that docker is fully functional with the new changes

    • Determined that docker, unlike podman, only assigns the host IP
      after the instance has been created
  • Updated the GitHub Actions to test both podman and docker

  • Used a simple acceptance test for validation since the upstream beaker
    tests are wired for Vagrant

  • Fail if the container is in an inaccessible state instead of trying to
    SSH forever

* Ensure that docker is fully functional with the new changes
  * Determined that docker, unlike podman, only assigns the host IP
    after the instance has been created

* Updated the GitHub Actions to test both podman and docker

* Used a simple acceptance test for validation since the upstream beaker
  tests are wired for Vagrant

* Fail if the container is in an inaccessible state instead of trying to
  SSH forever
Copy link
Contributor

@genebean genebean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trevor-vaughan is the use of the custom docker-api gem intentional? Also, do you know if the fixes in core beaker you mentioned are being worked on?

@trevor-vaughan
Copy link
Contributor Author

@genebean Yes. The podman tests won't work without it (it's almost merged). The updates in core beaker aren't being worked to my knowledge since I just discovered the issue.

@genebean genebean merged commit f2fb731 into voxpupuli:master Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants