Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
From what I can gather the key lookup of
PortBinding
in network settings is wrong, but rather than assume it never exists, I kept behavior but ifPorts
exists, which is used in unit tests and what my Docker daemon exposes, then use that instead.So unit tests look like what I see on my Docker daemon:
I also updated unit tests to test using
0.0.0.0
since that's what the code sets when setting up the SSH port binding.