Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional Docker port bindings #54

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

treydock
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #54 (9c0d804) into master (b47d868) will increase coverage by 0.25%.
The diff coverage is 100.00%.

❗ Current head 9c0d804 differs from pull request most recent head 1cfe5ce. Consider uploading reports for the commit 1cfe5ce to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   84.82%   85.08%   +0.25%     
==========================================
  Files           1        1              
  Lines         290      295       +5     
==========================================
+ Hits          246      251       +5     
  Misses         44       44              
Impacted Files Coverage Δ
lib/beaker/hypervisor/docker.rb 85.08% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47d868...1cfe5ce. Read the comment docs.

Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane to me. But would be nice if @trevor-vaughan could take a look at well.

@trevor-vaughan
Copy link
Contributor

Sorry that this took so long to check! This looks good to me.

@trevor-vaughan trevor-vaughan merged commit 141be98 into voxpupuli:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants