Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ssh-keygen -A on Red Hat-based distros & SuSE/SLES #73

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Dec 21, 2022

This is present in at least EL7 and we don't test on older versions
anymore. The benefit is that keys for all supported types are generated.

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work on opensuse/sles too.

@ekohl
Copy link
Member Author

ekohl commented Dec 21, 2022

I'll take your word for it.

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Patch and project coverage have no change.

Comparison is base (9a4e935) 84.74% compared to head (57f156c) 84.74%.

❗ Current head 57f156c differs from pull request most recent head 87d4396. Consider uploading reports for the commit 87d4396 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   84.74%   84.74%           
=======================================
  Files           1        1           
  Lines         295      295           
=======================================
  Hits          250      250           
  Misses         45       45           
Impacted Files Coverage Δ
lib/beaker/hypervisor/docker.rb 84.74% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ekohl ekohl changed the title Use ssh-keygen -A on Red Hat-based distros Use ssh-keygen -A on Red Hat-based distros & SuSE/SLES Dec 21, 2022
This is present in at least EL7 and we don't test on older versions
anymore. The benefit is that keys for all supported types are generated.
@ekohl ekohl merged commit 072bea7 into voxpupuli:master Mar 17, 2023
@ekohl ekohl deleted the use-ssh-keygen branch March 17, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants