-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop legacy oracle data #322
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
=========================================
+ Coverage 0.71% 0.73% +0.01%
=========================================
Files 15 15
Lines 1811 1764 -47
=========================================
Hits 13 13
+ Misses 1798 1751 -47 ☔ View full report in Codecov by Sentry. |
Perhaps Puppet folks can weigh in here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd actually like to continue using oracle
. Writing out oraclelinux
is tedious. We didn't change centos
to centoslinux
and also don't write centosstream
.
In puppet_metadata we can make sure to generate the right name.
I cleaned it up for the future. I think that's legacy code that could be removed with the next major release. |
5878994
to
d94ccf0
Compare
c2e8039
to
b093fc6
Compare
Result of a discussion we had in voxpupuli#321
Result of a discussion we had in #321