(QENG-7422) Add wait_time and max_connection_tries to exec.reboot #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit there was no way to customize the behavior of the Host::Unix::Exec.reboot method. This meant that if you had a host that took a particularly long time to come back from a reboot, your tests would fail. This commit adds two parameters, `wait_time` and `max_connection_tries`, which will modify how long to wait before checking on the host after rebooting it and how many times to attempt connecting to the host after the reboot. As noted in the method comment, the `max_connection_tries` uses a fibbonacci backoff so increasing it will not increase the time spent waiting for reconnection in a linear way. Additionally, I have added specs for these parameters and mocked out `Kernel.sleep` in the specs so that they run faster.
|
@highb You can run our full test suites with any changes, if you
|
|
@trevor-vaughan That is super helpful, thank you! |
|
Found a small issue with the default nodeset for running the tests, put up a PR to fix it. simp/rubygem-simp-beaker-helpers#119 edit: Determined a fix for the issue in beaker itself by setting a sensible |
|
I got the https://github.com/simp/rubygem-simp-beaker-helpers tests to pass using a Beaker branch containing this PR and #1628 so I think once #1628 is reviewed/merged and the acceptance tests are happy again, this is ready to review/merge. |
|
Jenkins, test this please |
mattkirby
approved these changes
Mar 4, 2020
genebean
requested changes
Mar 5, 2020
Prior to this commit if the `uptime` command did not reset after the provided `wait_time`, we would assume that the host wasn't going to reboot. This commit adds an `uptime_retries` parameter to the `Unix::Exec.reboot` method that specifies how many times Beaker should attempt to check the result of the `uptime` command before giving up on the host.
highb
force-pushed
the
QENG-7422_configurable_reboot_wait
branch
from
ffd92b6
to
b6f5ea4
Compare
|
Jenkins, test this please |
2 similar comments
|
Jenkins, test this please |
|
Jenkins, test this please |
|
@genebean Could you review again, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit there was no way to customize the behavior of the
Host::Unix::Exec.reboot method. This meant that if you had a host that
took a particularly long time to come back from a reboot, your tests
would fail.
This commit adds two parameters,
wait_timeandmax_connection_tries,which will modify how long to wait before checking on the host after
rebooting it and how many times to attempt connecting to the host after
the reboot. As noted in the method comment, the
max_connection_triesuses a fibbonacci backoff so increasing it will not increase the time
spent waiting for reconnection in a linear way.
Additionally, I have added specs for these parameters and mocked out
Kernel.sleepin the specs so that they run faster.