Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ruby 2.4/2.5/2.6 support #1767

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

bastelfreak
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Base: 74.94% // Head: 74.96% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (d999c9e) compared to base (de52e37).
Patch coverage: 66.66% of modified lines in pull request are covered.

❗ Current head d999c9e differs from pull request most recent head 50d1370. Consider uploading reports for the commit 50d1370 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1767      +/-   ##
==========================================
+ Coverage   74.94%   74.96%   +0.02%     
==========================================
  Files          82       82              
  Lines        4857     4853       -4     
==========================================
- Hits         3640     3638       -2     
+ Misses       1217     1215       -2     
Impacted Files Coverage Δ
lib/beaker/dsl/structure.rb 78.21% <0.00%> (ø)
lib/beaker/options/parser.rb 98.96% <ø> (ø)
lib/beaker/options/hosts_file_parser.rb 100.00% <100.00%> (+4.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bastelfreak
Copy link
Member Author

To not cause a huge diff, I didn't fix rubocop violations, but updated the .rubocop_todo.yml. I would like to do some cleanup in a followup PR.

.github/workflows/test.yml Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
.rubocop.yml Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
lib/beaker/dsl/structure.rb Outdated Show resolved Hide resolved
lib/beaker/options/parser.rb Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
.rubocop.yml Outdated Show resolved Hide resolved
.rubocop_todo.yml Outdated Show resolved Hide resolved
.rubocop_todo.yml Outdated Show resolved Hide resolved
.rubocop_todo.yml Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
.rubocop_todo.yml Outdated Show resolved Hide resolved
@bastelfreak bastelfreak merged commit 7727e3a into voxpupuli:master Feb 20, 2023
@bastelfreak bastelfreak deleted the ruby27 branch February 20, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants