Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fedora facts #89

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Update Fedora facts #89

merged 1 commit into from
Sep 14, 2018

Conversation

blackknight36
Copy link
Contributor

  • Added fact file for Fedora 28.
  • Fixed incorrect facter version in Fedora 26 fact file.

These facts were pulled from a live server running Fedora 28 x86_64.

* Added fact file for Fedora 28.
* Fixed incorrect facter version in Fedora 26 fact file.
@mcanevet mcanevet merged commit 1cbfd31 into voxpupuli:master Sep 14, 2018
@baurmatt
Copy link
Contributor

facts/2.5/fedora-28-x86_64.facts broke the spec tests as its not a valid JSON file.

@blackknight36
Copy link
Contributor Author

@baurmatt Sorry about that, I thought I ran the file through json-lint before I submitted it.

@baurmatt
Copy link
Contributor

@blackknight36 No worries! :) I've fixed it in #93 and also patched the Vagrantfile and get_facts.sh file for Fedora 28 support.

It probably wasn't detected by the CI because it was already broken due to some unrelated issue.

@blackknight36 blackknight36 deleted the update_fedora_facts branch September 18, 2018 18:08
@blackknight36
Copy link
Contributor Author

Thanks. On a related note, Fedora 29 is just around the corner. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants