Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why the module implements some logic when installing awscli-bundle.zip #146

Closed
danifr opened this issue Mar 17, 2016 · 1 comment
Closed

Why the module implements some logic when installing awscli-bundle.zip #146

danifr opened this issue Mar 17, 2016 · 1 comment

Comments

@danifr
Copy link
Member

danifr commented Mar 17, 2016

Shouldn't this installation be completely configurable via the $aws_cli_install param?
$aws_cli_install should be false by default and if the user wants to install it they just need to set it to true.

This change would let us get rid of this logic https://github.com/voxpupuli/puppet-archive/blob/master/manifests/params.pp#L27
@nanliu
Copy link
Contributor

nanliu commented Mar 17, 2016

This was intended to simplify the logic in a mixed environment, where the AWS CLI is automatically installed for systems running in AWS. Simply setting it as false would be easier logically, but I was trying to implement a convenient default.

Regarding #141, Dan mentioned openstack use the same metadata service so it will populate ec2_* facts (see https://projects.puppetlabs.com/issues/11640). I didn't anticipate this and since I don't have access to openstack environment, I haven't found the difference between them (in facter). @nibalizer, would you know off the top of your head?

If we can't sort this out soon, I agree we should just change the default to false and remove the logic since it's not working as intended.

nanliu added a commit to nanliu/puppet-archive that referenced this issue Mar 18, 2016
@nanliu
voxpupuliGH-146 set aws_cli_install default to false
f3d9e03 
Since at this point we can't determine difference between openstack and
AWS ec_* facts, we will default the install to false and let the end
user make the appropriate choice.
jyaworski added a commit that referenced this issue Mar 18, 2016
@jyaworski
Merge pull request #148 from nanliu/GH-146
d68c7b2 
GH-146 set aws_cli_install default to false
@nanliu nanliu closed this as completed Mar 18, 2016
randradas pushed a commit to randradas/puppet-archive that referenced this issue Oct 30, 2016
@nanliu @randradas
voxpupuliGH-146 set aws_cli_install default to false
074c018 
Since at this point we can't determine difference between openstack and
AWS ec_* facts, we will default the install to false and let the end
user make the appropriate choice.
cegeka-jenkins pushed a commit to cegeka/puppet-archive that referenced this issue Oct 23, 2017
@nanliu
voxpupuliGH-146 set aws_cli_install default to false
568ba24 
Since at this point we can't determine difference between openstack and
AWS ec_* facts, we will default the install to false and let the end
user make the appropriate choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nanliu @danifr