Solaris support with tests #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes to autofs_version fact Add solaris tests
dhollinger
approved these changes
Sep 13, 2017
|
Thanks, @Nekototori! |
ekohl
reviewed
Sep 13, 2017
| @@ -0,0 +1,12 @@ | |||
| Facter.add(:autofs_version) do | |||
| unless :osfamily == 'Solaris' | |||
There was a problem hiding this comment.
I expected that the confine already did this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase from the other PR regarding adding compatibility for Solaris.
Solaris already has the package, so require Package fails, they've all been changed to Class per suggestions in previous PR.
Additional testing and hiera specifics were added by @dhollinger , plus a fix to the autofs fact by @wyardley so that tests will complete without error on macs as well.