Run backup create with set +e if pruning is enabled #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The way @jay7x mentions should make it easier to not duplicate the whole command line as well. Just put the |
bastelfreak
force-pushed
the
set
branch
2 times, most recently
from
a634bb3
to
d06c51b
Compare
kenyon
reviewed
Nov 8, 2023
bastelfreak
force-pushed
the
set
branch
3 times, most recently
from
f5250f7
to
8643579
Compare
In case a file changes during a backup, borg will log a warning like this: ``` Nov 07 18:30:05 webserver01 borg-backup[849693]: Creating archive at "backup:webserver01::backup-20231107-183001" Nov 07 18:30:42 webserver01 borg-backup[849693]: /var/lib/postgresql/16/main/pg_wal/00000001000000010000004E: file changed while we backed it up Nov 07 18:30:59 webserver01 borg-backup[849693]: /var/lib/fail2ban/fail2ban.sqlite3: file changed while we backed it up ``` It will finish the backup, but the exit code will be 1. Because of the set -e at the top, the script will exit. If manage_prune is true, a prune command is configured. It won't be executed when a file change during a backup. We now add `|| true` to the backup create command.
jay7x
reviewed
Nov 9, 2023
jay7x
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a file changes during a backup, borg will log a warning like this:
It will finish the backup, but the exit code will be 1. Because of the set -e at the top, the script will exit. If manage_prune is true, a prune command is configured. It won't be executed when a file change during a backup.
We now add
|| trueto the backup create command.