Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 164: syslog plugin needs to be loaded as first plugin #166

Merged
merged 1 commit into from
Aug 15, 2014

Conversation

txaj
Copy link

@txaj txaj commented Jul 29, 2014

If the syslog plugin is not initialized as first plugin, other plugins
won't be able to log their startup/fail output at load time.

reported by bzed

@blkperl
Copy link
Member

blkperl commented Jul 30, 2014

Is there some way to get tests for this? A comment would be nice to explain why it is first.

@bzed
Copy link
Contributor

bzed commented Jul 30, 2014

why: man 5 collectd.conf:

The configuration is read and processed in order, i.e. from top to bottom. So the plugins are loaded in the order listed in this config file. It is a good idea to load any logging plugins first in order to catch messages from plugins during configuration. Also, the LoadPlugin option must occur before the appropriate  block.

actually it might make sense to load the logfile plugin at order 00, too.

@txaj
Copy link
Author

txaj commented Jul 30, 2014

well catched bzed.
Also after giving it a thought, it'd be nice to still let the user still to load something before those plugins if he wants to. Since the default order is 10, I suggest we put a default of 05 for both syslog and logfile

If the syslog plugin is not initialized as first plugin, other plugins
won't be able to log their startup/fail output at load time.

reported by bzed
blkperl added a commit that referenced this pull request Aug 15, 2014
Issue 164: syslog plugin needs to be loaded as first plugin
@blkperl blkperl merged commit 6454a63 into voxpupuli:master Aug 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants