Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fixtures #599

Closed
wants to merge 1 commit into from
Closed

Update fixtures #599

wants to merge 1 commit into from

Conversation

petems
Copy link
Member

@petems petems commented Dec 14, 2016

  • Make sure we're specifying versions from metadata

@bastelfreak
Copy link
Member

mhm, I'm not sure if we want that. In general we try to test against master to detect unreleased issues in our dependcies. This revealed several stdlib issues that I'm aware of and probably more. On the negative site we never know if our dependencies in metadata.json are working with the module or if they are outdated.

I would still prefer option 1 for all the unit tests. We can do real testing if correct dependencies in our acceptance tests.

@juniorsysadmin
Copy link
Member

juniorsysadmin commented Dec 20, 2016

I'd rather we didn't pin at all in fixtures, unless unit tests are breaking and a fix to accommodate a newer version is a long way off

@petems
Copy link
Member Author

petems commented Dec 20, 2016

Ok, withdrawn 👍

@petems petems closed this Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants