Purge config.d directory #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traylenator
reviewed
Dec 14, 2016
| @@ -53,6 +53,14 @@ | |||
| content => "This directory is managed by puppet but *.conf files are ignored from purging\n", | |||
| require => File['/etc/cvmfs/domain.d'], | |||
| } | |||
| file{'/etc/cvmfs/config.d/README.PUPPET': | |||
There was a problem hiding this comment.
Hi,
The domain.d/README and config.d/README may as well be an array of two files like you did for the
directory.
There was a problem hiding this comment.
True, but this also needs a require which has both parent directories in it. Alternatively, we could also define the dependencies outside of the file type which is probably better because you don't end up with the readme in config.d (or domain.d) depending on the domain.d (or config.d) directory.
Let me know which one you prefer and I change it.
|
@rwf14f sorry for delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove old configuration files which were created by cvmfs::mount when the mount is removed from puppet.