Drop support for Puppet 3 and 4 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
commented
Feb 20, 2020
| @@ -19,7 +28,7 @@ | |||
| $epel_gpgcheck = $epel::params::epel_gpgcheck, | |||
| $epel_repo_gpgcheck = $epel::params::epel_repo_gpgcheck, | |||
| $epel_metalink = $epel::params::epel_metalink, | |||
| $epel_managed = $epel::params::epel_managed, | |||
| Boolean $epel_managed = true, | |||
There was a problem hiding this comment.
puppet-strings can make use of defaults if they're here and not coming from params.pp
alexjfisher
commented
Feb 20, 2020
| # | ||
| # Actions: | ||
| # Import a RPM gpg key | ||
| # @api private |
There was a problem hiding this comment.
I'm pretty sure this is private given the require => File[$path],.
alexjfisher
commented
Feb 20, 2020
rnelson0
requested changes
Feb 20, 2020
| # path => "/etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-6" | ||
| # } | ||
| # | ||
| # @example Sample Usage |
There was a problem hiding this comment.
If it's private, does it still need an @example?
There was a problem hiding this comment.
Not really. I felt a bit bad about just nuking it though.
rnelson0
approved these changes
Feb 20, 2020
I've also started the migration to using data-types, puppet-strings and removing static parameters from params.pp.
alexjfisher
force-pushed
the
drop_puppet3and4
branch
from
18898e1
to
ef5192a
Compare
bastelfreak
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also started the migration to using data-types, puppet-strings and
removing static parameters from params.pp.