Make 'ssh' and 'ssh-ddos' jail names be consistent across operating systems #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traylenator
reviewed
Apr 30, 2018
|
The other names are either the name of the jail or the name of the filters. The filters seem to be "sshd-ddos" and "sshd" for all of them, which I guess is correct. The jail names seem to be |
… that sshd and sshd-ddos jails are enabled
|
@saibot94 nice to get the acceptance tests running as well. |
traylenator
reviewed
May 4, 2018
| ssh_log_file = '/var/log/secure' | ||
| ssh_jail = 'ssh' | ||
| # EPEL needs to be installed, otherwise it won't work | ||
| shell('wget http://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm') |
There was a problem hiding this comment.
Missed this, should not have been merged.
There was a problem hiding this comment.
By default ensuring the package epel-release is installed works on CentOS since it's carried in the extras repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adding the following code in the manifest:
and deploying it on a CentOS machine will result in no jails being configured, even though the documentation mentions that '['ssh', 'ssh-ddos']' are configured to run by default.
The problem is that the parameters the config is looking for on the CentOS templates are sshd and sshd-ddos.
This Pull Request (PR) fixes the following issues
Fixes #34