Enable acceptance tests for CentOS 6 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
May 4, 2018
metadata.json
Outdated
| @@ -31,7 +31,8 @@ | |||
| "operatingsystemrelease": [ | |||
| "12.04", | |||
| "14.04", | |||
| "16.04" | |||
| "16.04", | |||
| "18.04" | |||
There was a problem hiding this comment.
Odd indenting here due to mixing of tabs and spaces
There was a problem hiding this comment.
Looks better now.
traylenator
force-pushed
the
dropoldnodes
branch
2 times, most recently
from
1ce4c2e
to
b1be97f
Compare
|
Looks like the module also relies on LSB facts being present. |
This was referenced May 7, 2018
traylenator
changed the title
Since this module attemts to maintain `/etc/fail2ban/fail2ban.conf` for the case `package_ensure` is `absent` it can not rely on the package maintaining the directory and the directory must also be managed. Probably a lot of this `absent` vs `purged` should be ripped out.
|
Okay. I think this is worth another check now. |
|
@ekohl I think all comments addressed |
ekohl
approved these changes
May 15, 2018
cegeka-jenkins
pushed a commit
to cegeka/puppet-fail2ban
that referenced
this pull request
Mar 30, 2020
Enable acceptance tests for CentOS 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Enable acceptance tests for CentOS 6 and Ubuntu 18.04