repo_gpgcheck fails and can't be disabled

[silug]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 7.14.0
• Ruby: 2.7.5p203
• Distribution: CentOS Stream 8
• Module version: 4.3.0

How to reproduce (e.g Puppet code you use)

include gitlab_ci_runner

What are you seeing

# dnf --refresh --disablerepo=\* --enablerepo=runner_gitlab-runner makecache
runner_gitlab-runner                            661  B/s | 862  B     00:01    
runner_gitlab-runner                             20 kB/s | 3.1 kB     00:00    
runner_gitlab-runner                            911  B/s | 862  B     00:00    
Error: Failed to download metadata for repo 'runner_gitlab-runner': repomd.xml GPG signature verification error: Bad GPG signature

What behaviour did you expect instead

The repo metadata signing is broken upstream, but we should be able to disable repo_gpgcheck. This is not possible in the current code.

puppet-gitlab_ci_runner/manifests/repo.pp

Line 50 in f58780a

repo_gpgcheck => '1',

[silug]

https://github.com/voxpupuli/puppet-gitlab has the same issue, but because the repository configuration is specified in hiera, it's easy enough to override repo_gpgcheck (see voxpupuli/puppet-gitlab#401 for details). Ideally this module should be refactored to behave in a similar way, but this may require backwards-incompatible changes.

[silug]

Root cause of the failure: voxpupuli/puppet-gitlab#401 (comment)

[sharewax]

issue is still here.
for EL9 correct command for fixing it is rm -rf /var/cache/dnf/x86_64/9/runner_gitlab-runner-*