Fix application of augeas changes on a Centos7/RHEL7 machine. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue voxpupuli#11 against parent
bastelfreak
reviewed
Aug 29, 2018
manifests/pam/redhat.pp
Outdated
| ], | ||
| require => File["/etc/pam.d/${rule}"], | ||
| notify => Service['sshd'], | ||
| if ($::facts['os']['release']['major'] >= 7) { |
There was a problem hiding this comment.
Should now be done.
bastelfreak
added
bug
|
Thanks for the PR! Please take a look at the failing travis tests. |
|
there are still some travis tests failing, please have a look. Also please check the email address used in the commits, it is not associated with your github account. |
|
Work vs Home email. Added work email, so should be there now. |
|
Thanks! |
raphink
reviewed
Aug 31, 2018
| ], | ||
| require => File["/etc/pam.d/${rule}"], | ||
| notify => Service['sshd'], | ||
| if ($facts['os']['release']['major'] >= 7) { |
There was a problem hiding this comment.
Maybe this should be restricted to RedHat?
There was a problem hiding this comment.
good catch. @bekarau what do you think?
There was a problem hiding this comment.
The restriction to redhat is done in pam.pp; where this module is called from:
case $::operatingsystem {
/Debian|Ubuntu/ : {
googleauthenticator::pam::debian {$name:
ensure => $ensure,
mode => $mode,
}
}
/RedHat|CentOS/ : {
googleauthenticator::pam::redhat {$name:
ensure => $ensure,
mode => $mode,
}
}
default : { fail("not supported on ${::operatingsystem}") }
}
There was a problem hiding this comment.
Ah, my bad, I didn't see this was in redhat.pp!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Fixes the application of augeas changes on a Centos7/RHEL7 installation.
This Pull Request (PR) fixes the following issues
Fixes #11
Further comments
As I've not tested the newer augeas changes against older releases, I've put an explicit test for major release 7 or greater (assuming it won't change in the future either).