Implement grafana_folder resource type #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit + tests for grafana_folder type
* initial commit to implement grafana_folder resource type * add required parameters for grafana objects * remove references to dashboard objects (dashboard used as template) * update tests * remove whitespace for rubocop * rubocop fixes * fix global var assignment clause logic
|
Hi @alexconrey, thanks for the PR. Can you document the new type in the README.md add add acceptance tests for it? |
* initial commit to implement grafana_folder resource type * add required parameters for grafana objects * remove references to dashboard objects (dashboard used as template) * update tests * remove whitespace for rubocop * rubocop fixes * fix global var assignment clause logic * update README.md/created acceptance test for grafana_folder resource
* rubocop whitespace removal * updates to grafana_folder_spec.rb
|
@bastelfreak sure thing! I've created the requested acceptance tests as well as updated the |
|
Thanks for the awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
We found it useful to manage Grafana folders via Puppet. This type was heavily based on the code for
grafana_dashboardtype.