(SIMP-4206) Added organization provider and updated datasource provider

[heliocentric]

• Updated grafana datasource provider to allow datasources to be created
  on specific organizations
• Added grafana organization provider to allow organizations to be
  created
• Updated README to add more descriptive information for previous
  features as well as new

Fixes commercial/enterprise-meta#91
SIMP-4206 #close

[bastelfreak]

followingto -> following to

[bastelfreak]

2015?

[bastelfreak]

is that actually needed? The whole project uses the Apache-2 license. We try to keep the header short and simple, and don't add the license text to all files.

[bastelfreak]

Hi @heliocentric, thanks for the PR!

• I added a few inline comments, can you take a look at them?
• rubocop isn't happy, can you fix the warnings? Maybe autofix works with bundle exec rake rubocop:auto_correct
• Can you add a few tests for this?

[brandonrdn]

@bastelfreak With the new push from @heliocentric I believe I've fixed all of your concerns.

• The Copyright notices have been removed from new files (I copied them over from the other files that were created by bfraser to keep consistency).
• The syntax error has been fixed in the README
• New spec test created for organization provider
• Updated spec test for datasource provider
• Fixed all issues that rubocop had (0 issues currently)

Please let me know if there is anything else needed to complete this merge.

[bastelfreak]

Thanks, I will check the code later. I need to find out why travis isn't working for this PR.

[bastelfreak]

github UI isn't showing me any tests, but travis tells me it tested:
https://travis-ci.org/voxpupuli/puppet-grafana/builds/333847788
Can you take a look at the rubocop issue?

[brandonrdn]

@bastelfreak which rubocop issue are you referring to? The travis tests you linked are from the original request 4 days ago, doesn't look like they've been re-run.

[bastelfreak]

now travis is running again, let's see if it works

[bastelfreak]

@heliocentric @brandonrdn now we got issues :)

[brandonrdn]

Hey @bastelfreak, I fixed the failures with the spec tests, that was an issue on my end for testing before committing changes and thinking they passed. As of right now, all spec tests pass and rubocop has 0 issues. I'll be pushing up from my fork to the SIMP fork, so you should see the push soon.

[brandonrdn]

@bastelfreak The newest updates are pushed. You may need to restart Travis again.

[brandonrdn]

So close. I have the fix for the last few rubocop fails. It isn't telling me locally that it's broken.

[bastelfreak]

rubocop sitll isn't happy. Can you have a look? you can execute it locally with:

bundle exec rake rubocop

you can invoke the autofixmagic with:

bundle exec rake rubocop:auto_correct

you maybe need to install the gems, if you didn't do that:

bundle install --path .vendor/ --without development --without system_tests --without release

[brandonrdn]

@bastelfreak I'm not sure why it's doing this, but I did all 3 previously. I bundle installed, ran the rubocop check, auto_corrected what I could, and manually fixed the rest. When I pushed up my last changes rubocop showed 0 issues. Next push should work. Fingers crossed.

[bastelfreak]

now it looks good. Thanks for the work!