Fixes bug in the latest push from PR #102, that doesn't use the _keysdir path when creating keys #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build is failing ...but it looks like it was also failing in #102 as well..... |
|
@hunner: i'm not familiar with RuboCop but i'll try to google to see if I can fix the error. |
|
Thanks, looking into it. Yeah, don't know why rubocop is failing :( |
| @@ -186,7 +186,7 @@ The following parameters are available for the hiera class: | |||
| This is useful for configuring backend-specific parameters. | |||
| Default: `''` | |||
| * `keysdir` | |||
| Directory for hiera to manage for eyaml keys. | |||
| Directory for hiera to manage for eyaml keys. This is the path where /keys should be managed not the full path to the /keys directory. | |||
There was a problem hiding this comment.
@smbambling I was also thinking that the hiera::keysdir parameter would be the full path to keys/, like keysdir => /etc/puppet/eyaml_keys or whatever. What do you think?
There was a problem hiding this comment.
It could be...
where it bites you as you would need to munge that into a new variable to use with
exec { 'createkeys':
user => $owner, user => $owner,
cwd => $confdir, + cwd => $keysdir,
I was also trying to keep with the pattern used for _keysdir in init.pp
|
Made this more generic so that keysdir is full path. |
hunner
added a commit
that referenced
this pull request
Jan 27, 2016
Fixes bug in the latest push from PR #102, that doesn't use the _keysdir path when creating keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #102 caused a bug that did not obey the _keysdir parameter when creating keys. It only created them in $confdir/keys...which caused a failure if a different path was used.