Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make jenkins NOT download plugins again and again and again.. #98

Closed
wants to merge 1 commit into from

Conversation

KlavsKlavsen
Copy link

No description provided.

@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@jchristi
Copy link
Contributor

@KlavsKlavsen are you specifying a plugin version? Pinning a version should cause it to only download once. With your patch though, it will make updating a plugin not work.

@KlavsKlavsen
Copy link
Author

You're right. I didn't think about that. is this supposed to support "latest" feature somehow? or is it just: "whatveer is available when we installed" or "specific version" ?
If that's the case - perhaps the plugin name should be $pluginname-$versionrequested.xpi ?
then creates would work - and we could make sure to clean up disabled plugins, by setting force and purge to true on the folder (then only the files created in the run will stay there)

@jchristi
Copy link
Contributor

I always use exact plugin versions, so I can't speak definitively on the other cases. What was your use case where you were seeing multiple downloads?

@KlavsKlavsen
Copy link
Author

I had lots of plugins where I didn't want any specific version.. just the latest - and then it kept re-downloading them.

@jchristi
Copy link
Contributor

What exact version of the codebase are you running?

@KlavsKlavsen
Copy link
Author

the codebase? you mean puppet-jenkins module? latest from github.

@jchristi
Copy link
Contributor

I use a heavily modded version myself, so I'll have to setup a test environment with the usptream code to see if I can reproduce. Not sure when I'll be able to get around to that though.

@rtyler rtyler added this to the Version 1.0.0 milestone Feb 24, 2014
@rtyler rtyler added the bug label Feb 25, 2014
@rtyler
Copy link

rtyler commented Feb 26, 2014

I don't think we're going to be able to reasonable solve this for the Edgar (1.0.0) release coming up in a few days, but this will be handled more appropriately by the code to fix #12.

I think the best case scenario for the near term is just to document the behavior

@rtyler rtyler closed this in cc8d1d8 Feb 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants