Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keepalived_version fact not working #61

Closed
aamerik opened this issue Jan 27, 2015 · 7 comments
Closed

keepalived_version fact not working #61

aamerik opened this issue Jan 27, 2015 · 7 comments
Labels
bug Something isn't working

Comments

@aamerik
Copy link

aamerik commented Jan 27, 2015

Hi, I'm having issues with every agent run warning me on

Could not retrieve fact='keepalived_version', resolution='<anonymous>': undefined method `[]' for nil:NilClass

Can someone please help :)

@aamerik
Copy link
Author

aamerik commented Jan 27, 2015

I see the fact does

Facter::Util::Resolution.exec('keepalived --version 2>&1').lines.first.match(/Keepalived v(\d\.\d\.\d) .+/)[1]

but my keepalived on RHEL outputs version as:

keepalived -v
Keepalived v1.2.13 (08/07,2014)

Is this the issue?

@arioch arioch added the bug Something isn't working label Jan 27, 2015
@arioch
Copy link
Contributor

arioch commented Feb 1, 2015

@petems could you take a look at this?

@petems
Copy link
Member

petems commented Feb 1, 2015

@arioch Should be an easy enough fix I think:

Keepalived v(\d+\.\d+\.\d+)

Gimme a sec, I'll add a spec to catch this in the future too! 👍

@arioch
Copy link
Contributor

arioch commented Feb 1, 2015

Thanks @petems!

petems added a commit to petems/puppet-keepalived that referenced this issue Feb 1, 2015
TDD FTW, test written first! 😄
@petems
Copy link
Member

petems commented Feb 1, 2015

Fixed in #63

@arioch arioch added bug Something isn't working and removed bug Something isn't working labels Feb 1, 2015
@petems
Copy link
Member

petems commented Mar 26, 2015

@arioch You can close this now 👍

@arioch
Copy link
Contributor

arioch commented Mar 26, 2015

Alright, thanks again.

@arioch arioch closed this as completed Mar 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants