Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to manage the package outside the module #249

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

kibidouil
Copy link
Contributor

Pull Request (PR) description

I need the possibility to fix the version of keepalived, so, like service_manage, I introduce package_manage to install keepalived from another puppet module.

This Pull Request (PR) fixes the following issues

n/a

manifests/init.pp Outdated Show resolved Hide resolved
manifests/install.pp Outdated Show resolved Hide resolved
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can you please combine your commits in a single one?

From your working directory:

git rebase -i origin/master # Interactively rewrite history

This will bring your editor. Keep the first line unchanged, and replace pick with squash for all subsequent lines. Save and quit, your editor will allow you to combine the commit messages in a single commit message.

Then push your updated branch:

git push -f            # Send the changes (-f is required because we re-wrote history)

@bastelfreak bastelfreak added the enhancement New feature or request label Oct 4, 2021
@kibidouil
Copy link
Contributor Author

Commits are merged into one commit.

@smortex smortex merged commit 865b7ae into voxpupuli:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants