Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid leaking passwords in puppet apply in templates. #40

Closed
wants to merge 3 commits into from

Conversation

ernstae
Copy link

@ernstae ernstae commented Jan 31, 2020

Users may have elasticsearch.password key/value pair in the kibana::config hash and this file should be sensitized and not leaked when applying (and diff is output)

Pull request acceptance prerequisites:

  • Signed the CLA (if not already signed)
  • Rebased/up-to-date with base branch
  • Updated CHANGELOG.md with patch notes (if necessary)
  • Any relevant docs (README.markdown or inline documentation) updated (if necessary)
  • Updated CONTRIBUTORS (if you would like attribution)
  • Tests pass CI

Users may have `elasticsearch.password` key/value pair and this file should be sensitized.
@ernstae ernstae mentioned this pull request Jan 31, 2020
@ernstae ernstae marked this pull request as ready for review January 31, 2020 10:01
@ernstae ernstae requested a review from tylerjl February 5, 2020 23:21
@ernstae
Copy link
Author

ernstae commented Jan 4, 2022

Closing this, since it's no longer relevant

@ernstae ernstae closed this Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant