#91: Cron should also run with space in certonly title #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @siebrand, thanks for the PR! Can you squash those commits into one? |
siebrand
force-pushed
the
issue-91-space-in-title-bad-cron
branch
from
96c9184
to
18497b2
Compare
|
@bastelfreak: Done. Hadn't done that before. Was much easier than I expected. ( |
Issue voxpupuli#91 reports that creating a letsencrypt::certonly resource with a title containing a space will create a cron entry that will never run. That's because it will create a cron entry like this: 10 22 * * * /cron_scripts_path/renew-title with space.sh That executes /cron_scripts_path/renew-title that obviously does not exist. When the full cron command is put in quotes, it will run as expected.
siebrand
force-pushed
the
issue-91-space-in-title-bad-cron
branch
from
18497b2
to
c1bad4d
Compare
|
@bastelfreak: Conflicts resolved. |
juniorsysadmin
added
bug
|
@siebrand Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #91 reports that creating a letsencrypt::certonly resource with a
title containing a space will create a cron entry that will never run.
That's because it will create a cron entry like this:
That executes
/cron_scripts_path/renew-titlethat obviously does notexist. When the full cron command is put in quotes, it will run as
expected.