-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modulesync 4.1.0 / Drop EoL Puppet 5 / Drop VCS install method #235
Conversation
Fedora 31 timed out on creating the Docker container, restarted the build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some odd is happening on Fedora 31 + Puppet 5. Failing in the same way now as before:
An error occurred while loading ./spec/acceptance/letsencrypt_plugin_dns_rfc2136_spec.rb.
Given VCS mode has been broken for a while, should we drop it? |
yeah I think we should rip it out :( |
Fedora 30 and 31 are EOL while Fedora 32 is supported. So is Fedora 33, but Puppet doesn't build AIO packages for that.
I took the liberty of leaving your commits out and remove VCS install method support. This must be mentioned in the changelog somewhere. |
It's green now. Sometimes the easiest thing is to just remove things :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a large number of changes so I'd appreciate if someone else also took a look.
This has been stuck on an old version and so far nobody has updated it to a recent version that actually works. Distribution packages just work.
Support for Fedora 30 and 31 was removed in voxpupuli#235.
modulesync 4.0.0