Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modulesync 4.1.0 / Drop EoL Puppet 5 / Drop VCS install method #235

Merged
merged 7 commits into from
Jun 25, 2021

Conversation

bastelfreak
Copy link
Member

modulesync 4.0.0

@ekohl
Copy link
Member

ekohl commented Nov 25, 2020

Fedora 31 timed out on creating the Docker container, restarted the build.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some odd is happening on Fedora 31 + Puppet 5. Failing in the same way now as before:

An error occurred while loading ./spec/acceptance/letsencrypt_plugin_dns_rfc2136_spec.rb.

@bastelfreak bastelfreak changed the title modulesync 4.0.0 modulesync 4.1.0 Apr 27, 2021
@bastelfreak bastelfreak changed the title modulesync 4.1.0 modulesync 4.1.0 / Drop EoL Puppet 5 / certbot: Update v0.39.0->v1.14.0 May 2, 2021
@ekohl
Copy link
Member

ekohl commented Jun 25, 2021

Given VCS mode has been broken for a while, should we drop it?

@bastelfreak
Copy link
Member Author

yeah I think we should rip it out :(

bastelfreak and others added 5 commits June 25, 2021 11:49
Fedora 30 and 31 are EOL while Fedora 32 is supported. So is Fedora 33,
but Puppet doesn't build AIO packages for that.
@ekohl
Copy link
Member

ekohl commented Jun 25, 2021

I took the liberty of leaving your commits out and remove VCS install method support. This must be mentioned in the changelog somewhere.

@ekohl ekohl removed the tests-fail label Jun 25, 2021
@ekohl ekohl changed the title modulesync 4.1.0 / Drop EoL Puppet 5 / certbot: Update v0.39.0->v1.14.0 modulesync 4.1.0 / Drop EoL Puppet 5 / Drop VCS install method Jun 25, 2021
@ekohl
Copy link
Member

ekohl commented Jun 25, 2021

It's green now. Sometimes the easiest thing is to just remove things :)

@ekohl ekohl linked an issue Jun 25, 2021 that may be closed by this pull request
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a large number of changes so I'd appreciate if someone else also took a look.

This has been stuck on an old version and so far nobody has updated it
to a recent version that actually works. Distribution packages just
work.
@bastelfreak bastelfreak merged commit 1605317 into master Jun 25, 2021
@bastelfreak bastelfreak deleted the modulesync branch June 25, 2021 10:15
kenyon added a commit to treveradams/puppet-letsencrypt that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants