Add fastcgi index #1062
Add fastcgi index #1062
Conversation
|
@elmobp can you add tests? |
|
Sure! I think the location bits needs some work though So we could do something along the lines of I will look at doing this in another PR though |
|
@elmobp That sounds very reasonable. Will you be able to add spec tests for this particular PR though? |
|
hey @wyardley sorry been tied up on a project I will get these done Wednesday |
|
@wyardley hows that look? |
|
@elmobp Sorry, didn't mean to rush you! Test looks good, voxpupuli usually asks that the commits be squashed back to a single one (rebase / force-push the branch). I'll make one other request, sorry that I didn't notice it before. |
manifests/resource/server.pp
Outdated
| @@ -254,6 +255,7 @@ | |||
| Optional[String] $proxy_buffering = undef, | |||
| Array $resolver = [], | |||
| Optional[String] $fastcgi = undef, | |||
| $fastcgi_index = undef, | |||
There was a problem hiding this comment.
Can you prefix this with Optional[String] to match the rest?
|
Done! |
|
@elmobp Looks good to me, sorry there were so many hoops to jump through on this one. Merging. |
| @@ -159,7 +161,7 @@ | |||
| is_expected.to contain_apt__source('nginx').with( | |||
| 'location' => "https://nginx.org/packages/#{operatingsystem.downcase}", | |||
| 'repos' => 'nginx', | |||
| 'key' => '573BFD6B3D8FBC641079A6ABABF5BD827BD9BF62' | |||
| 'key' => { 'id' => '573BFD6B3D8FBC641079A6ABABF5BD827BD9BF62' } | |||
There was a problem hiding this comment.
I think this was from another commit? Next time, rebase rather than merge master.
| @@ -37,21 +37,21 @@ | |||
| apt::source { 'nginx': | |||
| location => "https://nginx.org/packages/${distro}", | |||
| repos => 'nginx', | |||
| key => '573BFD6B3D8FBC641079A6ABABF5BD827BD9BF62', | |||
| key => {'id' => '573BFD6B3D8FBC641079A6ABABF5BD827BD9BF62'}, | |||
There was a problem hiding this comment.
Here too... @bastelfreak is this Ok, since this is one that was already merged, just kind of confusing commit message.... Or should I revert?
There was a problem hiding this comment.
Want a fresh PR? to fix them
There was a problem hiding this comment.
@elmobp yeah, let's just do that.
Add fastcgi index
Add fastcgi index
Add the fastcgi index to the server resource