calls service instead of init.d #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix service start/restart Ubuntu (which doesn't allow init.d)
|
It would be better to restart service via puppet |
|
@j-martin this is unnecessary on Ubuntu since the init scripts from Debian upstream perform a config test before starting, restarting and reloading. When restarting/reloading it's tested before the daemon's stopped so it's not possible to fail a config test and be left with no running daemon (i.e. it's only stopped if the config test passes). This has been true since version 0.7.61-1, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=539778. All currently supported Debian & Ubuntu versions will see this behavior. I recommend closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix service start/restart Ubuntu (which doesn't allow init.d)