Fix a config error in the last sample in README

[huandu]

Passenger cgi param was wrong. See diff for details.

[3flex]

@huandu, I'm assuming this is related to http://docs.puppetlabs.com/guides/passenger.html#notes-on-ssl-verification. It would have been good to reference this for context in your issue description.

Having said that this looks correct. The current example in README would require a change to puppet.conf which isn't mentioned so the example should be corrected to work properly with the defaults.

[huandu]

@3flex The current example looks right but doesn't work on my server. Nginx always returns 403 errors for urls which restrict access by certname, e.g. /report/*. I investigated this issue for several hours yesterday and finally found this solution.

If puppet doc is correct, it could be a bug or regression in puppet v3.4.2, which is the version I'm using. However, it seems using HTTP_X_CLIENT_DN/HTTP_X_CLIENT_VERIFY is always safer. I'd recommend to use them instead of the value in current example.

[3flex]

@huandu Sorry, I wasn't clear! When I said the "current example" which would also need a puppet.conf update I was talking about what's in master, not your proposal. When I said "this looks correct" I was talking about your PR.

Your proposal looks good and looks like it aligns with Puppet's recommended SSL config for Passenger. 👍

[huandu]

@3flex Ah, well, I misunderstood your point. My bad and thanks for your explanation!

[jfryman]

Thanks for the code! 🙇

[jfryman]

Great discussion. I like that we're talking about better understanding of the module and how changes might have impact. Helps tremendously to consider the stability of this module. 🍻