Update puppetlabs-concat and fix tests on Oracle Linux

[sagepe]

Pull Request (PR) description

The primary goal of this PR was to update the puppetlabs-concat dependency to permit the use of puppetlabs-stdlib 9.x.

Recently added tests for Oracle Linux 7 were failing. The necessary packages needed EPEL to be available, but even when this was added the installation of nagios-plugins-all failed due to dependency errors. I tried Oracle Linux 7, 8 and 9, so I'm not sure whether this module can support Oracle Linux easily.

If Oracle Linux support is important, there are more details from the failed CI runs in our fork (see here for 7 and here for 8 and 9).

[alexjfisher]

I'd prefer not to remove Oracle Linux support like this. Happy to merge a PR that updates concat dependency even if OL builds are still failing.

I think it's just missing a repo though. See https://bugzilla.redhat.com/show_bug.cgi?id=1768303#c7

[sagepe]

I'd prefer not to remove Oracle Linux support like this. Happy to merge a PR that updates concat dependency even if OL builds are still failing.

Fair enough.

I think it's just missing a repo though. See https://bugzilla.redhat.com/show_bug.cgi?id=1768303#c7

Ah yes - I think you're right. I've just quickly tested this on an OEL7 docker container, and nagios-plugins-all installed cleanly:

yum install oracle-epel-release-el7
yum-config-manager --enable ol7_optional_latest
yum install nagios-plugins-all

We just use Debian based distros, but it feels to me like the optimal way to support this would be in the module itself by configuring EPEL for the distros where it's needed (I'm guessing probably most of the RedHat family systems?) and then for Oracle adding install_options => ['--enablerepo', 'ol7_optional_latest'] to the package declaration (the versions specific bits would need catering for ideally, too).

Or would you just want to handle this in the acceptance tests, similar to the current way EPEL is installed for CentOS here? I'm not sure how best to get this to work in terms of getting the optional repo enabled, however.

[alexjfisher]

If the module were to handle it, I think it would have to be configurable as folks often use their own yum mirrors etc.
I think handling it in the acceptance tests would be fine. (Perhaps a small note in the README if you can think of anything concise to add?)

[sagepe]

So this reinstates and fixes the tests on Oracle Linux, in what I hope is a suitably forward-compatible fashion.