add flush() to dbindex for modification of existing index #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kronos-pbrideau could you please rebase to see if it fixes #103 now that I've merge the acceptance test that prove the bug? |
|
@kronos-pbrideau I think we don't have to use flush as there is only on property to update, we only have to code the |
|
@kronos-pbrideau could you please rebase and don't use flush as it is not necessary? |
|
LGTM thanks @kronos-pbrideau |
mcanevet
added a commit
that referenced
this pull request
Nov 19, 2015
add flush() to dbindex for modification of existing index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done it, before checking upstream, and probably solve #103