Make it easy to customize cnf/crt/csr/key paths #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @robbat2 ! Thank you for your PR, but it seems it breaks the unit tests (especially the second commit). You might have a look here for example: You should update the unit tests in order to ensure the new cnf_* values are taken into account as expected. Thank you for your update. Cheers, C. |
|
Thank you for this @robbat2 . Could you rebase on master and squash your commits please? And then I'll merge. |
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
robbat2
force-pushed
the
path_config
branch
from
14f4323
to
57dbe6b
Compare
|
Rebased+squashed as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.