use voxpupuli/archive to download composer #274
Conversation
| creates => $path, | ||
| proxy_type => $proxy_type, | ||
| proxy_server => $proxy_server, | ||
| require => [Class['::php::cli'],Package['curl']], |
There was a problem hiding this comment.
require Package['curl'] not needed now
| ) { | ||
|
|
||
| if $caller_module_name != $module_name { | ||
| warning('php::composer::auto_update is private') | ||
| } | ||
|
|
||
| $env = $proxy_type? { | ||
| undef => {}, |
There was a problem hiding this comment.
It appears this isn't puppet 3 compatible. From https://docs.puppet.com/puppet/3.8/reference/lang_conditional.html#values
Values may be any of the following:
Any literal value, with the exception of hash literals
There was a problem hiding this comment.
i'll have to return undef then.
| creates => $path, | ||
| proxy_type => $proxy_type, | ||
| proxy_server => $proxy_server, | ||
| require => Class['::php::cli'], |
There was a problem hiding this comment.
This dependency looks a bit odd. But it was there before, so maybe removing it will have unintended consequences.
There was a problem hiding this comment.
composer requires php to run, so this makes sense.
There was a problem hiding this comment.
to run, but not to download. Maybe it should just be included instead?
rather than using a hand-crafted curl call, we use voxpupuli/archive to download composer. This has the benefit that it doesn't require us to $manage_curl. But we also remove `$environment`! This variable name is poorly chosen. Overriding it (or even just setting it to `undef`), could mean that someone's `hiera()` lookups are failing, as soon as they enter our module! This pull-request addresses #273.
|
$environment is not needed with archive, because archive has specific proxy settings. Just make sure you pass them through so we can set them, when you make the change. |
|
@edestecd |
|
rather than using a hand-crafted curl call, we use voxpupuli/archive to
download composer. This has the benefit that it doesn't require us to
$manage_curl. But we also remove
$environment! This variable name ispoorly chosen. Overriding it (or even just setting it to
undef), couldmean that someone's
hiera()lookups are failing, as soon as they enterour module!
This pull-request addresses #273.