[Ubuntu ppa] Add support for php7.1 and prevent installation of php7.1 when trying to use php5.6 only #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful to prevent installation of php7.1-cli when installing php-apcu in a php5.6 environment (Ubuntu + https://launchpad.net/~ondrej/+archive/ubuntu/php) See oerdnj/deb.sury.org#563
The workaround also needs to be applied on Ubuntu < 16.04 when using the php ppa from Ondrej.
Vincent--
changed the title
Vincent--
changed the title
bastelfreak
reviewed
Mar 6, 2018
| @@ -27,7 +27,9 @@ | |||
| } | |||
|
|
|||
| # Default PHP come with xml module and no seperate package for it | |||
| if $::operatingsystem == 'Ubuntu' and versioncmp($::operatingsystemrelease, '16.04') >= 0 { | |||
| if $::operatingsystem == 'Ubuntu' and | |||
There was a problem hiding this comment.
please don't use topscope fact variables. Instead use the new $facts hash
|
Thanks for opening this issue. It hasn't seen activity in a while, so I'm going to close the issue. This doesn't mean that we don't think this issue is valid, we're just trying to assess what issues are still relevant. If you still need this(even if you're not willing to work on it yourself) please feel free to reopen it. Again thanks for opening the issue, users who report bugs and ask for features are some of the most important players in the open source community. Feel free to hop by #voxpupuli on irc.freenode.net if you'd like to chat with us about any of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to prevent installation of php7.1-cli when installing php-apcu
in a php5.6 environment (Ubuntu + https://launchpad.net/~ondrej/+archive/ubuntu/php)
See oerdnj/deb.sury.org#563