-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial ubuntu 18.04 support #428
Conversation
@jkroepke thanks for the PR! Can you add both distributions to the metadata.json? We need to make sure that facterdb has mocked facts before we merge this. Can you take a look at the failing spec tests? |
17.10 and 18.04 are currently missing: https://github.com/camptocamp/facterdb/tree/master/facts/2.5 |
Like #429 (comment) only the Debian 8 Test are failing. Since 18.04 isn't released at this moment (and the puppet spec test infrastructure not ready for 18.04 yet) I suggest to not add the 18.04 release to the supported os. I starting with 18.04 yesterday to prepare my code for bionic. I required some puppet workarounds because puppet itself isn't 18.04 ready. Thats why I'm calling this initial support. |
ugh debian... We can't merge this before facterdb is updated and Ubuntu 18.04 is released, but the change to metadata.json is required. |
Whats the status of the PR? About the failing test, see #430 |
@jkroepke currently i have a little lack of time for fixing the debian tests, which block quite all PR see #433 (comment) |
Hey @jkroepke, could you please rebase? |
Sure. |
rebased and added a fix |
Ubuntu 18.04 ships 7.2 by default.
https://packages.ubuntu.com/bionic/php