Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial ubuntu 18.04 support #428

Merged
merged 3 commits into from
May 5, 2018
Merged

Add initial ubuntu 18.04 support #428

merged 3 commits into from
May 5, 2018

Conversation

jkroepke
Copy link
Contributor

Ubuntu 18.04 ships 7.2 by default.

https://packages.ubuntu.com/bionic/php

@bastelfreak
Copy link
Member

@jkroepke thanks for the PR! Can you add both distributions to the metadata.json? We need to make sure that facterdb has mocked facts before we merge this. Can you take a look at the failing spec tests?

@bastelfreak bastelfreak added needs-work not ready to merge just yet tests-fail labels Mar 14, 2018
@bastelfreak
Copy link
Member

17.10 and 18.04 are currently missing: https://github.com/camptocamp/facterdb/tree/master/facts/2.5

@jkroepke
Copy link
Contributor Author

Like #429 (comment)

only the Debian 8 Test are failing.

Since 18.04 isn't released at this moment (and the puppet spec test infrastructure not ready for 18.04 yet) I suggest to not add the 18.04 release to the supported os.

I starting with 18.04 yesterday to prepare my code for bionic. I required some puppet workarounds because puppet itself isn't 18.04 ready. Thats why I'm calling this initial support.

See: puppetlabs/puppet#6706

@bastelfreak
Copy link
Member

ugh debian...


We can't merge this before facterdb is updated and Ubuntu 18.04 is released, but the change to metadata.json is required.

@jkroepke
Copy link
Contributor Author

jkroepke commented Apr 7, 2018

Whats the status of the PR?

About the failing test, see #430

@c33s
Copy link
Member

c33s commented Apr 8, 2018

@jkroepke currently i have a little lack of time for fixing the debian tests, which block quite all PR

see #433 (comment)

@bastelfreak
Copy link
Member

Hey @jkroepke, could you please rebase?

@jkroepke
Copy link
Contributor Author

jkroepke commented May 5, 2018

Sure.

@bastelfreak
Copy link
Member

rebased and added a fix

@bastelfreak bastelfreak added enhancement New feature or request and removed needs-work not ready to merge just yet tests-fail labels May 5, 2018
@bastelfreak bastelfreak merged commit 3aed175 into voxpupuli:master May 5, 2018
@jkroepke jkroepke deleted the patch-3 branch May 6, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants