Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch the dotdeb repo url to https #431

Merged
merged 1 commit into from
May 5, 2018

Conversation

bastelfreak
Copy link
Member

No description provided.

@c33s
Copy link
Member

c33s commented Mar 17, 2018

careful with this one. then we need to ensure we also require https://packages.debian.org/stretch/apt-transport-https and maybe also https://packages.debian.org/stretch/ca-certificates
-> bc break and possible trouble/conflicts in existing setups. people partly have this already installed.

maybe we should plan a major release, where we can add #409

@bastelfreak
Copy link
Member Author

I need to doublecheck, but I think the puppetlabs-apt module automatically installs the apt-transport-https package if a repo url starts with https

@juniorsysadmin
Copy link
Member

@c33s c33s requested review from c33s and removed request for c33s March 18, 2018 11:48
@c33s c33s mentioned this pull request Mar 20, 2018
Copy link
Member

@sebastianrakel sebastianrakel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More HTTPS!!!! Looks good to me

@bastelfreak bastelfreak merged commit ff15ff1 into voxpupuli:master May 5, 2018
@bastelfreak bastelfreak deleted the repourl branch May 5, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants