Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension config for zend_extensions #498

Closed
wants to merge 1 commit into from

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Nov 16, 2018

Fixes a glitch introduced in #479.

When an extension is zend = true, there is no extension entry in the $final_settings hash, but a zend_extension one.

/cc @amateo

Fixes a glitch introduced in voxpupuli#479.

When an extension is `zend = true`, there is no `extension` entry in the `$final_settings` hash, but a `zend_extension` one.

/cc @amateo
@bastelfreak
Copy link
Member

Hi @mpdude, thanks for the patch. Are you able to contribute a unit- or acceptance test?

@bastelfreak bastelfreak added bug Something isn't working needs-tests labels Nov 16, 2018
@vox-pupuli-tasks
Copy link

Dear @mpdude, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

2 similar comments
@vox-pupuli-tasks
Copy link

Dear @mpdude, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @mpdude, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@mpdude
Copy link
Contributor Author

mpdude commented Jan 5, 2022

#567 seems to resolve this.

@mpdude mpdude closed this Jan 5, 2022
@mpdude mpdude deleted the patch-1 branch January 9, 2022 22:00
@mpdude mpdude restored the patch-1 branch January 9, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants