Add/Fix data types of all parameters #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
commented
Aug 19, 2021
We can make the code more expressive and shorted by using a proper data type.
smortex
changed the title
These parameters had mixed types before data-types where added. Use the more appropriate data type for each of them.
Before we got data types, $security_limit_extensions was an optional array of string defaulting to undef. It is now an array of string defaulting to an empty array. We do not want to emit security.limit_extensions when this array is empty.
|
So, I do not know how much we can trust the test suite 🤡… To be sure I applied the changes on our production infrastructure and it seems to be fine 😄 (I only saw changes from PR which have already been merged into the Ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
No functional change. Fixes for invalid/wrong/weird data types will be part of another PR.The initial intention was to have a backward compatible PR (this one) and one that fixes the wrong types, but because the code is inconsistent, it is not possible to add data types in a backward compatible way.
This Pull Request (PR) fixes the following issues
n/a