Fix ruby 1.8.7 quirks #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`type/acl.rb` had a scoping/namespacing problem where a block parameter `|perm|` was used inside of a block with its own block parameter `|perm|`. Changed the inner param to `|tmp_perm|` fixed this for 1.8.7. `acl_spec.rb` was comparing arrays using the `eq`[1] matcher - which cares about array order - instead of the `match_array`[2] matcher, which disregards order. [1] - https://www.relishapp.com/rspec/rspec-expectations/v/3-3/docs/built-in-matchers/equality-matchers [2] - https://www.relishapp.com/rspec/rspec-expectations/v/3-3/docs/built-in-matchers/contain-exactly-matcher
dobbymoodge
force-pushed
the
ruby187_specfix
branch
from
e3ba9e0
to
fd44d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type/acl.rbhad a scoping/namespacing problem where a block parameter|perm|was used inside of a block with its own block parameter|perm|. Changed the inner param to|tmp_perm|fixed this for 1.8.7.acl_spec.rbwas comparing arrays using theeqmatcher - which cares about array order - instead of thematch_arraymatcher, which disregards order.