Do not downcase acl group/user names when checking for insync?. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch has conflicts that must be resolved |
type.`set_insync` downcases the entire acl line before comparison with the current acl. This effectively causes the resource's state to never be in sync if you use any group, or username with uppercase characters. Also, remove redundant call to provider.`permission`.
|
resolved. |
|
Thanks. Tests will be improved after #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type.
set_insyncdowncases the entire acl line before comparison with thecurrent acl. This effectively causes the resource's state to never be in
sync if you use any group, or username with uppercase characters.
Also, remove redundant call to provider.
permission.Also fixes the tests.