Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding class to create alerts #24

Merged
merged 4 commits into from
Dec 13, 2016
Merged

adding class to create alerts #24

merged 4 commits into from
Dec 13, 2016

Conversation

snubba
Copy link
Contributor

@snubba snubba commented Nov 2, 2016

Add the possibility to create alerts

@brutus333
Copy link
Collaborator

Really nice code. Please tell me if it's working on puppet version 3.x with future_parser enabled.
I am not merging right now the PR since we need to check for possible compatibility issues. The rest of code is written and tested on puppet 3.x.

@snubba
Copy link
Contributor Author

snubba commented Nov 29, 2016

Yes, the code seems to also build in puppet 3.7.2

@brutus333 brutus333 merged commit e9a4d4e into voxpupuli:master Dec 13, 2016
roidelapluie pushed a commit that referenced this pull request Jun 21, 2017
Use same namespace for Prometheus and its components
vide pushed a commit to billyperformance/puppet-prometheus that referenced this pull request Jun 22, 2017
* adding class to create alerts

* fix puppet syntax in alert class

* fix puppet syntax in alert class

* fix name Value in Labels
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
* adding class to create alerts

* fix puppet syntax in alert class

* fix puppet syntax in alert class

* fix name Value in Labels
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
Use same namespace for Prometheus and its components
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
* adding class to create alerts

* fix puppet syntax in alert class

* fix puppet syntax in alert class

* fix name Value in Labels
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Use same namespace for Prometheus and its components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants