-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix restart_on_change and add tests to Class[prometheus] #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! |
bastelfreak
added
bug
Something isn't working
enhancement
New feature or request
labels
Oct 23, 2017
sathieu
added a commit
to sathieu/puppet-prometheus
that referenced
this pull request
Oct 23, 2017
Following voxpupuli#83, and preparing tests for voxpupuli#48.
@sathieu Thanks! We use the PR titles in our changelogs. Could you update it to something that highlights what the bug fix is? I dunno, something like |
sathieu
changed the title
Test Class[prometheus] and small fix
Fix restart_on_change and add tests to Class[prometheus]
Oct 23, 2017
knackjax
pushed a commit
to knackjax/puppet-prometheus
that referenced
this pull request
Nov 21, 2017
Following voxpupuli#83, and preparing tests for voxpupuli#48.
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
Test Class[prometheus] and small fix
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
Following voxpupuli#83, and preparing tests for voxpupuli#48.
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Test Class[prometheus] and small fix
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Following voxpupuli#83, and preparing tests for voxpupuli#48.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a complete coverage of all resources included by Class[prometheus] (except 4 "content" params).
Also fixes an undefined variable.