Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restart_on_change and add tests to Class[prometheus] #83

Merged
merged 2 commits into from
Oct 23, 2017

Conversation

sathieu
Copy link

@sathieu sathieu commented Oct 23, 2017

This includes a complete coverage of all resources included by Class[prometheus] (except 4 "content" params).

Also fixes an undefined variable.

@bastelfreak
Copy link
Member

Thanks!

@bastelfreak bastelfreak added bug Something isn't working enhancement New feature or request labels Oct 23, 2017
@bastelfreak bastelfreak merged commit 7553b16 into voxpupuli:master Oct 23, 2017
@sathieu sathieu deleted the more-spec branch October 23, 2017 14:26
sathieu added a commit to sathieu/puppet-prometheus that referenced this pull request Oct 23, 2017
@alexjfisher
Copy link
Member

@sathieu Thanks! We use the PR titles in our changelogs. Could you update it to something that highlights what the bug fix is?

I dunno, something like Fix restart_on_change and add tests?

@sathieu sathieu changed the title Test Class[prometheus] and small fix Fix restart_on_change and add tests to Class[prometheus] Oct 23, 2017
knackjax pushed a commit to knackjax/puppet-prometheus that referenced this pull request Nov 21, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
Test Class[prometheus] and small fix
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Test Class[prometheus] and small fix
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants