Add stdlib version requirement to Modulefile #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add requirement on version >= 3.0.0 of stdlib to Modulefile. Version 3.x of stdlib supports Puppet 2.7.x and Puppet 3. Without this, versions of librarian-puppet <= 0.9.10 choke.
nibalizer
added a commit
that referenced
this pull request
Feb 5, 2014
Add stdlib version requirement to Modulefile
|
@bderickson Thanks for the help! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some trouble installing your module using librarian-puppet version 0.9.10. I finally tracked it down to stdlib not having a version in Modulefile. Here's a gist illustrating the problem using the master branch of your repo and my branch that adds a version to stdlib.
https://gist.github.com/bderickson/8815816
I believe I could use the latest version of the librarian-puppet-maestrodev fork of librarian-puppet and things worked fine, but we can't upgrade to that for other reasons.
Version 3.0.0 of stdlib supports Puppet 2.7.x while later versions of stdlib drop that support, so I think specifying the version as I have should be pretty safe since versions of Puppet < 2.7 are EOL.