Fix running puppetboard without vhost #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waipeng
force-pushed
the
apache_conf
branch
2 times, most recently
from
4f44116
to
2afb65b
Compare
bastelfreak
reviewed
Oct 17, 2020
| @@ -13,6 +13,7 @@ | |||
| # @param ldap_bind_authoritative Determines if other authentication providers are used when a user can be mapped to a DN but the server cannot bind with the credentials | |||
| # @param ldap_require_group LDAP group to require on login | |||
| # @param ldap_require_group_dn LDAP group DN for LDAP group | |||
| # @param virtualenv_dir Set location where virtualenv will be installed | |||
There was a problem hiding this comment.
thanks for the fix. can you also run bundle exec rake reference to update the REFERENCE.md?
Running puppetboard without a vhost was not tested, so the changes that we made in voxpupuli#302 were just for puppetboard::apache::vhost, and did not extend to puppetboard::apache::conf Fix up puppetboard::apache::conf the same way, and add a test
|
more changes to REFERENCE.md than expected, can you check if this is ok? |
|
thanks, looks fine :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Running puppetboard without a vhost was not tested, so the changes that
we made in #302 were just for puppetboard::apache::vhost, and did not
extend to puppetboard::apache::conf
Fix up puppetboard::apache::conf the same way, and add a test