Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.0.0 release #633

Merged
merged 1 commit into from
Sep 14, 2017
Merged

7.0.0 release #633

merged 1 commit into from
Sep 14, 2017

Conversation

wyardley
Copy link
Contributor

This release includes some breaking(ish) changes, so we're going to do a major bump.

alexjfisher
alexjfisher requested changes Sep 13, 2017
View reviewed changes
CHANGELOG.md Outdated
@@ -4,7 +4,57 @@ All notable changes to this project will be documented in this file.
Each new release typically also includes the latest modulesync defaults.
These should not impact the functionality of the module.

## [v6.0.0](https://github.com/voxpupuli/puppet-rabbitmq/tree/v6.0.0) (2017-09-06)
## [v6.0.1-rc0](https://github.com/voxpupuli/puppet-rabbitmq/tree/v6.0.1-rc0) (2017-09-13)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run changelog task after updating the version. :)

alexjfisher
alexjfisher reviewed Sep 13, 2017
View reviewed changes
CHANGELOG.md
- Rabbitmq\_user\_permissions parser fails for empty string [\#172](https://github.com/voxpupuli/puppet-rabbitmq/issues/172)
- Error on using puppet resource rabbitmq\_user [\#147](https://github.com/voxpupuli/puppet-rabbitmq/issues/147)
- Resolve issue with "puppet resource rabbitmq\_user" failing \(\#147\) [\#629](https://github.com/voxpupuli/puppet-rabbitmq/pull/629) ([wyardley](https://github.com/wyardley))
- BREAKING: Ensure python package \(adds manage\_python option\) [\#623](https://github.com/voxpupuli/puppet-rabbitmq/pull/623) ([wyardley](https://github.com/wyardley))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe tempted to label the BREAKING changes 'enhancement's so that they feature prominently in the changelog?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep them as bug only; the ones that are not already tagged as enhancements are not really enhancements, so I don't think we should tweak it just for the higher placement in the changelog (though I like the idea of the breaking changes section that @bastelfreak was working on).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I don't think the "breaking" ones for this release are super breaking, most of them should not affect users of recent RabbitMQ versions IMHO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added enhancement to the most important one.

@coveralls
Copy link

coveralls commented Sep 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 78.625% when pulling 57ec4fa on wyardley:release_7_0_0 into 3a5268d on voxpupuli:master.

@coveralls
Copy link

coveralls commented Sep 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 78.625% when pulling 73a4247 on wyardley:release_7_0_0 into 3a5268d on voxpupuli:master.

@coveralls
Copy link

coveralls commented Sep 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 78.625% when pulling a71c9c3 on wyardley:release_7_0_0 into 3a5268d on voxpupuli:master.

@wyardley wyardley force-pushed the release_7_0_0 branch 2 times, most recently from 62ce92b to 361b391 Compare September 13, 2017 23:15
@coveralls
Copy link

coveralls commented Sep 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 78.625% when pulling 62ce92b on wyardley:release_7_0_0 into 3a5268d on voxpupuli:master.

@coveralls
Copy link

coveralls commented Sep 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 78.625% when pulling 361b391 on wyardley:release_7_0_0 into 3a5268d on voxpupuli:master.

@wyardley
Copy link
Contributor Author

@alexjfisher version was fixed yesterday, and I cleaned up the changelog. Just re-ran to catch #634 as a bug in the Changelog. Can you re-review?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.625% when pulling 08e7f8e on wyardley:release_7_0_0 into 3a5268d on voxpupuli:master.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 14, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 78.625% when pulling 08e7f8e on wyardley:release_7_0_0 into 3a5268d on voxpupuli:master.

@wyardley wyardley merged commit c2f864b into voxpupuli:master Sep 14, 2017
@wyardley wyardley deleted the release_7_0_0 branch October 18, 2017 22:40
Slm0n87 pushed a commit to Slm0n87/puppet-rabbitmq that referenced this pull request Mar 7, 2019
@wyardley
Merge pull request voxpupuli#633 from wyardley/release_7_0_0
11316e9 
7.0.0 release
cegeka-jenkins pushed a commit to cegeka/puppet-rabbitmq that referenced this pull request Mar 26, 2021
@wyardley
Merge pull request voxpupuli#633 from wyardley/release_7_0_0
22f6c36 
7.0.0 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjfisher alexjfisher alexjfisher approved these changes

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wyardley @coveralls @alexjfisher @bastelfreak