-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentinel init/upstart file doesn't exist #18
Comments
@cdent, could you please look into this? |
Yeah, can do tomorrow. Up til now all my testing has been rpm-based distros. I'll take a look at Ubuntu tomorrow. BTW: There should be yet another pull request on the sentinel support coming from one of my colleagues tomorrow: The way the sentinel.pp requires the redis package is flaky and not properly puppet idiomatic. Clearly I have no idea what I'm doing ... :) |
That sounds great, thanks! |
In the long term I reckon this is a bug in debian, so I've reported one there. In the short term I guess we need to stub in an init script of our own. What's the best way to do that? |
@cdent, this should get you going pretty fast: https://github.com/jordansissel/pleaserun |
Thanks. I'm going to pause on implementing this until #19 has resolved (more comments over there in a moment) as the place to hook in the changes will be more clear then. |
Awesome, thanks! |
* When installing sentinel on the same node as redis, duplicate declaration error occurs * This is because it was originally wrapped in an ensure_resource * This was removed in b5174b2 * We should also remove the sentinel ensure_resource * This was originally added because Debian machines have a dedicated redid-sentinel package, whereas RedHat flavour machines do not * Instead, include the redis class so we have the variables we need * Add logic installing the redid-sentinel package on Debian-flavour * See voxpupuli#18 for more context
* When installing sentinel on the same node as redis, duplicate declaration error occurs * This is because it was originally wrapped in an ensure_resource * This was removed in b5174b2 * We should also remove the sentinel ensure_resource * This was originally added because Debian machines have a dedicated redid-sentinel package, whereas RedHat flavour machines do not * Instead, include the redis class so we have the variables we need * Add logic installing the redid-sentinel package on Debian-flavour * See voxpupuli#18 for more context
* When installing sentinel on the same node as redis, duplicate declaration error occurs * This is because it was originally wrapped in an ensure_resource * This was removed in b5174b2 * We should also remove the sentinel ensure_resource * This was originally added because Debian machines have a dedicated redid-sentinel package, whereas RedHat flavour machines do not * Instead, include the redis class so we have the variables we need * Add logic installing the redid-sentinel package on Debian-flavour * See voxpupuli#18 for more context
* When installing sentinel on the same node as redis, duplicate declaration error occurs * This is because it was originally wrapped in an ensure_resource * This was removed in b5174b2 * We should also remove the sentinel ensure_resource * This was originally added because Debian machines have a dedicated redid-sentinel package, whereas RedHat flavour machines do not * Instead, include the redis class so we have the variables we need * Add logic installing the redid-sentinel package on Debian-flavour * See #18 for more context
* When installing sentinel on the same node as redis, duplicate declaration error occurs * This is because it was originally wrapped in an ensure_resource * This was removed in b5174b2 * We should also remove the sentinel ensure_resource * This was originally added because Debian machines have a dedicated redid-sentinel package, whereas RedHat flavour machines do not * Instead, include the redis class so we have the variables we need * Add logic installing the redid-sentinel package on Debian-flavour * See voxpupuli#18 for more context
When trying to install sentinel (
class { 'redis::sentinel': }
) on Ubuntu 14.04, the following error appears:I would expect that there would be an init or upstart script in place that would start the sentinel service.
Building a template for the sentinel service should probably do the trick.
Thank you for an awesome module!
The text was updated successfully, but these errors were encountered: