Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel init/upstart file doesn't exist #18

Closed
antonlindstrom opened this issue Jan 14, 2015 · 7 comments
Closed

Sentinel init/upstart file doesn't exist #18

antonlindstrom opened this issue Jan 14, 2015 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@antonlindstrom
Copy link

When trying to install sentinel (class { 'redis::sentinel': }) on Ubuntu 14.04, the following error appears:

Error: /Stage[main]/Redis::Sentinel/Service[redis-sentinel]: Could not find init script or upstart conf file for 'redis-sentinel'

I would expect that there would be an init or upstart script in place that would start the sentinel service.

Building a template for the sentinel service should probably do the trick.

Thank you for an awesome module!

@arioch arioch self-assigned this Jan 14, 2015
@arioch
Copy link
Contributor

arioch commented Jan 14, 2015

@cdent, could you please look into this?

@arioch arioch added the bug Something isn't working label Jan 14, 2015
@cdent
Copy link
Contributor

cdent commented Jan 14, 2015

Yeah, can do tomorrow. Up til now all my testing has been rpm-based distros. I'll take a look at Ubuntu tomorrow.

BTW: There should be yet another pull request on the sentinel support coming from one of my colleagues tomorrow: The way the sentinel.pp requires the redis package is flaky and not properly puppet idiomatic.

Clearly I have no idea what I'm doing ... :)

@antonlindstrom
Copy link
Author

That sounds great, thanks!

@cdent
Copy link
Contributor

cdent commented Jan 15, 2015

In the long term I reckon this is a bug in debian, so I've reported one there.

In the short term I guess we need to stub in an init script of our own. What's the best way to do that?

@arioch
Copy link
Contributor

arioch commented Jan 15, 2015

@cdent, this should get you going pretty fast: https://github.com/jordansissel/pleaserun

@cdent
Copy link
Contributor

cdent commented Jan 15, 2015

Thanks. I'm going to pause on implementing this until #19 has resolved (more comments over there in a moment) as the place to hook in the changes will be more clear then.

@antonlindstrom
Copy link
Author

Awesome, thanks!

@arioch arioch closed this as completed Jun 2, 2015
petems added a commit to petems/puppet-redis that referenced this issue Apr 28, 2017
* When installing sentinel on the same node as redis, duplicate 
declaration error occurs
* This is because it was originally wrapped in an ensure_resource 
* This was removed in b5174b2
* We should also remove the sentinel ensure_resource
* This was originally added because Debian machines have a dedicated
redid-sentinel package, whereas RedHat flavour machines do not
* Instead, include the redis class so we have the variables we need
* Add logic installing the redid-sentinel package on Debian-flavour
* See voxpupuli#18 for more context
petems added a commit to petems/puppet-redis that referenced this issue Apr 28, 2017
* When installing sentinel on the same node as redis, duplicate 
declaration error occurs
* This is because it was originally wrapped in an ensure_resource 
* This was removed in b5174b2
* We should also remove the sentinel ensure_resource
* This was originally added because Debian machines have a dedicated
redid-sentinel package, whereas RedHat flavour machines do not
* Instead, include the redis class so we have the variables we need
* Add logic installing the redid-sentinel package on Debian-flavour
* See voxpupuli#18 for more context
petems added a commit to petems/puppet-redis that referenced this issue Apr 28, 2017
* When installing sentinel on the same node as redis, duplicate 
declaration error occurs
* This is because it was originally wrapped in an ensure_resource 
* This was removed in b5174b2
* We should also remove the sentinel ensure_resource
* This was originally added because Debian machines have a dedicated
redid-sentinel package, whereas RedHat flavour machines do not
* Instead, include the redis class so we have the variables we need
* Add logic installing the redid-sentinel package on Debian-flavour
* See voxpupuli#18 for more context
petems added a commit that referenced this issue Apr 29, 2017
* When installing sentinel on the same node as redis, duplicate 
declaration error occurs
* This is because it was originally wrapped in an ensure_resource 
* This was removed in b5174b2
* We should also remove the sentinel ensure_resource
* This was originally added because Debian machines have a dedicated
redid-sentinel package, whereas RedHat flavour machines do not
* Instead, include the redis class so we have the variables we need
* Add logic installing the redid-sentinel package on Debian-flavour
* See #18 for more context
cegeka-jenkins pushed a commit to cegeka/puppet-redis that referenced this issue Feb 16, 2021
* When installing sentinel on the same node as redis, duplicate 
declaration error occurs
* This is because it was originally wrapped in an ensure_resource 
* This was removed in b5174b2
* We should also remove the sentinel ensure_resource
* This was originally added because Debian machines have a dedicated
redid-sentinel package, whereas RedHat flavour machines do not
* Instead, include the redis class so we have the variables we need
* Add logic installing the redid-sentinel package on Debian-flavour
* See voxpupuli#18 for more context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants